RSPEED-3313: inline single-use helpers and drop redundant None assignments in rlsapi_v1#1996
Open
major wants to merge 1 commit into
Open
RSPEED-3313: inline single-use helpers and drop redundant None assignments in rlsapi_v1#1996major wants to merge 1 commit into
major wants to merge 1 commit into
Conversation
- Inline _get_cla_version, _get_configured_default_model_name, _is_verbose_enabled, and _get_prompt_template at their sole call sites - Reduce _compile_prompt_template lru_cache maxsize from 8 to 1 since only one system prompt exists at a time Signed-off-by: Major Hayden <major@redhat.com>
Contributor
WalkthroughThe ChangesRLSAPI v1 infer path cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
major
force-pushed
the
ponytail/rlsapi-cleanup
branch
from
2c6c4ac to
7508746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor of
src/app/endpoints/rlsapi_v1.pyto reduce indirection and redundant code._get_cla_version,_get_configured_default_model_name,_is_verbose_enabled, and_get_prompt_templateat their sole call sites_compile_prompt_templatelru_cachemaxsize from 8 to 1 (only one system prompt exists at a time)No behavior change. All 63 existing unit tests pass without modification.